Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correction of misplacement of self loops in diagrams #1274

Merged
merged 1 commit into from
Jul 5, 2022
Merged

Correction of misplacement of self loops in diagrams #1274

merged 1 commit into from
Jul 5, 2022

Conversation

a-sr
Copy link
Collaborator

@a-sr a-sr commented Jul 5, 2022

Deactivates middle position for unconnected port labels to prevent misplacement on self loops (#1273)

@a-sr a-sr added the diagrams Problems with diagram synthesis label Jul 5, 2022
@a-sr a-sr requested a review from edwardalee July 5, 2022 17:07
@a-sr a-sr mentioned this pull request Jul 5, 2022
Closed
edwardalee
edwardalee approved these changes Jul 5, 2022
View reviewed changes
Copy link
Collaborator

@edwardalee edwardalee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@edwardalee edwardalee merged commit 2011cca into master Jul 5, 2022
@edwardalee edwardalee deleted the port-labels branch July 5, 2022 17:56
@edwardalee
Copy link
Collaborator

Thanks for the (temporary) fix!

@lhstrh lhstrh changed the title Deactivate middle position for labels on unconnencted ports Correct misplacement of self loops in diagrams Jul 20, 2022
@lhstrh lhstrh changed the title Correct misplacement of self loops in diagrams Correction of misplacement of self loops in diagrams Jul 20, 2022
@lhstrh lhstrh added bug Something isn't working bugfix and removed bug Something isn't working labels Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwardalee edwardalee edwardalee approved these changes

Assignees
No one assigned
Labels
bugfix diagrams Problems with diagram synthesis
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@a-sr @edwardalee @lhstrh